[Review] SE-0178: Add unicodeScalars property to Character


(Ted Kremenek) #1

Hello Swift community,

The review of SE-0178: Add unicodeScalars property to Character begins now and runs through May 17, 2017.

The proposal is available here:

https://github.com/apple/swift-evolution/blob/master/proposals/0178-character-unicode-view.md
Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at:

https://lists.swift.org/mailman/listinfo/swift-evolution
or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:

Proposal link:

https://github.com/apple/swift-evolution/blob/master/proposals/0178-character-unicode-view.md
Reply text

Other replies
What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:

What is your evaluation of the proposal?
Is the problem being addressed significant enough to warrant a change to Swift?
Does this proposal fit well with the feel and direction of Swift?
If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
More information about the Swift evolution process is available at:

https://github.com/apple/swift-evolution/blob/master/process.md
Thank you,
Ted (Review Manager)


(Rien) #2

• What is your evaluation of the proposal?

+1

  • Is the problem being addressed significant enough to warrant a change to Swift?

Its not a change but an extension to the language that feels entirely natural.

  • Does this proposal fit well with the feel and direction of Swift?

Yes, see above,

  • If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

Not really, as the String type in swift is fairly complex. However I have done a fair bit of string parsing, and this change will make string parsing easier and more like ascii-string parsing.

  • How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

Quick reading. It does not seem very complicated.

Regards,
Rien

Site: http://balancingrock.nl
Blog: http://swiftrien.blogspot.com
Github: http://github.com/Balancingrock
Project: http://swiftfire.nl - A server for websites build in Swift

···

On 12 May 2017, at 22:41, Ted Kremenek via swift-evolution <swift-evolution@swift.org> wrote:

Hello Swift community,

The review of SE-0178: Add unicodeScalars property to Character begins now and runs through May 17, 2017.

The proposal is available here:

https://github.com/apple/swift-evolution/blob/master/proposals/0178-character-unicode-view.md

Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at:

https://lists.swift.org/mailman/listinfo/swift-evolution

or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:

Proposal link:

https://github.com/apple/swift-evolution/blob/master/proposals/0178-character-unicode-view.md

Reply text

Other replies
What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:

More information about the Swift evolution process is available at:

https://github.com/apple/swift-evolution/blob/master/process.md

Thank you,
Ted (Review Manager)

_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution


(Howard Lovatt) #3

+1

-- Howard.

···

On 13 May 2017, at 6:41 am, Ted Kremenek <kremenek@apple.com> wrote:

Hello Swift community,

The review of SE-0178: Add unicodeScalars property to Character begins now and runs through May 17, 2017.

The proposal is available here:

https://github.com/apple/swift-evolution/blob/master/proposals/0178-character-unicode-view.md

Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at:

https://lists.swift.org/mailman/listinfo/swift-evolution

or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:

Proposal link:

https://github.com/apple/swift-evolution/blob/master/proposals/0178-character-unicode-view.md

Reply text

Other replies
What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:

What is your evaluation of the proposal?
Is the problem being addressed significant enough to warrant a change to Swift?
Does this proposal fit well with the feel and direction of Swift?
If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
More information about the Swift evolution process is available at:

https://github.com/apple/swift-evolution/blob/master/process.md

Thank you,
Ted (Review Manager)

_______________________________________________
swift-evolution-announce mailing list
swift-evolution-announce@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution-announce


(Tony Allevato) #4

Hello Swift community,

The review of *SE-0178: Add unicodeScalars property to Character* begins
now and runs through *May 17, 2017*.

The proposal is available here:

https://github.com/apple/swift-evolution/blob/master/proposals/0178-character-unicode-view.md

Reviews are an important part of the Swift evolution process. All reviews
should be sent to the swift-evolution mailing list at:

https://lists.swift.org/mailman/listinfo/swift-evolution

or, if you would like to keep your feedback private, directly to the
review manager. When replying, please try to keep the proposal link at the
top of the message:

Proposal link:

https://github.com/apple/swift-evolution/blob/master/proposals/0178-character-unicode-view.md
Reply text

Other replies

What goes into a review?

The goal of the review process is to improve the proposal under review
through constructive criticism and, eventually, determine the direction of
Swift. When writing your review, here are some questions you might want to
answer in your review:

   - What is your evaluation of the proposal?

Obvious +1. I don't have much else to say; this is a solid and useful

addition.

   - Is the problem being addressed significant enough to warrant a
   change to Swift?

   - Does this proposal fit well with the feel and direction of Swift?

Yes. Swift already has some of the best Unicode handling among languages

today, so fleshing out that support is welcome.

···

On Fri, May 12, 2017 at 1:51 PM Ted Kremenek via swift-evolution < swift-evolution@swift.org> wrote:

   - If you have used other languages or libraries with a similar
   feature, how do you feel that this proposal compares to those?
   - How much effort did you put into your review? A glance, a quick
   reading, or an in-depth study?

Quick read.

More information about the Swift evolution process is available at:

https://github.com/apple/swift-evolution/blob/master/process.md

Thank you,
Ted (Review Manager)
_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution


(Nicholas Maccharoli) #5

+1

- Nick

···

2017年5月13日(土) 10:06 Howard Lovatt via swift-evolution < swift-evolution@swift.org>:

+1

-- Howard.

On 13 May 2017, at 6:41 am, Ted Kremenek <kremenek@apple.com> wrote:

Hello Swift community,

The review of *SE-0178: Add unicodeScalars property to Character* begins
now and runs through *May 17, 2017*.

The proposal is available here:

https://github.com/apple/swift-evolution/blob/master/proposals/0178-character-unicode-view.md

Reviews are an important part of the Swift evolution process. All reviews
should be sent to the swift-evolution mailing list at:

https://lists.swift.org/mailman/listinfo/swift-evolution

or, if you would like to keep your feedback private, directly to the
review manager. When replying, please try to keep the proposal link at the
top of the message:

Proposal link:

https://github.com/apple/swift-evolution/blob/master/proposals/0178-character-unicode-view.md
Reply text

Other replies

What goes into a review?

The goal of the review process is to improve the proposal under review
through constructive criticism and, eventually, determine the direction of
Swift. When writing your review, here are some questions you might want to
answer in your review:

   - What is your evaluation of the proposal?
   - Is the problem being addressed significant enough to warrant a
   change to Swift?
   - Does this proposal fit well with the feel and direction of Swift?
   - If you have used other languages or libraries with a similar
   feature, how do you feel that this proposal compares to those?
   - How much effort did you put into your review? A glance, a quick
   reading, or an in-depth study?

More information about the Swift evolution process is available at:

https://github.com/apple/swift-evolution/blob/master/process.md

Thank you,
Ted (Review Manager)

_______________________________________________
swift-evolution-announce mailing list
swift-evolution-announce@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution-announce

_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution


(Howard Lovatt) #6

It would be nice if character was made to be like a string of exactly
length 1 (cannot be empty) and implemented the new string protocol like the
new string slice does. This way string, string slice, and character could
be used interchangeably when programming to the protocol.

  -- Howard.

···

On 13 May 2017 at 11:52, Nicholas Maccharoli <nmaccharoli@gmail.com> wrote:

+1

- Nick
2017年5月13日(土) 10:06 Howard Lovatt via swift-evolution <
swift-evolution@swift.org>:

+1

-- Howard.

On 13 May 2017, at 6:41 am, Ted Kremenek <kremenek@apple.com> wrote:

Hello Swift community,

The review of *SE-0178: Add unicodeScalars property to Character* begins
now and runs through *May 17, 2017*.

The proposal is available here:

https://github.com/apple/swift-evolution/blob/master/
proposals/0178-character-unicode-view.md

Reviews are an important part of the Swift evolution process. All reviews
should be sent to the swift-evolution mailing list at:

https://lists.swift.org/mailman/listinfo/swift-evolution

or, if you would like to keep your feedback private, directly to the
review manager. When replying, please try to keep the proposal link at the
top of the message:

Proposal link:

https://github.com/apple/swift-evolution/blob/master/
proposals/0178-character-unicode-view.md
Reply text

Other replies

What goes into a review?

The goal of the review process is to improve the proposal under review
through constructive criticism and, eventually, determine the direction of
Swift. When writing your review, here are some questions you might want to
answer in your review:

   - What is your evaluation of the proposal?
   - Is the problem being addressed significant enough to warrant a
   change to Swift?
   - Does this proposal fit well with the feel and direction of Swift?
   - If you have used other languages or libraries with a similar
   feature, how do you feel that this proposal compares to those?
   - How much effort did you put into your review? A glance, a quick
   reading, or an in-depth study?

More information about the Swift evolution process is available at:

https://github.com/apple/swift-evolution/blob/master/process.md

Thank you,
Ted (Review Manager)

_______________________________________________
swift-evolution-announce mailing list
swift-evolution-announce@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution-announce

_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution