[Review] SE-0162 Package Manager Custom Target Layouts


(Rick Ballard) #1

Hello Swift community,

The review of "SE-0162 Package Manager Custom Target Layouts" begins now and runs through April 10, 2017. The proposal is available here:

  https://github.com/apple/swift-evolution/blob/master/proposals/0162-package-manager-custom-target-layouts.md

Reviews are an important part of the Swift evolution process. All Swift Package Manager reviews should be sent to the swift-evolution and swift-build-dev mailing lists at

  https://lists.swift.org/mailman/listinfo/swift-evolution
  https://lists.swift.org/mailman/listinfo/swift-build-dev

or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:

Proposal link:

https://github.com/apple/swift-evolution/blob/master/proposals/0162-package-manager-custom-target-layouts.md

Reply text

Other replies

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:

* What is your evaluation of the proposal?
* Is the problem being addressed significant enough to warrant a change to the Swift Package Manager?
* Does this proposal fit well with the feel and direction of Swift?
* If you have used other languages, libraries, or package managers with a similar feature, how do you feel that this proposal compares to those?
* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

More information about the Swift evolution process is available at

  https://github.com/apple/swift-evolution/blob/master/process.md

Thank you,

- Rick Ballard

Review Manager


(Joseph Heck) #2

Proposal link:

https://github.com/apple/swift-evolution/blob/master/proposals/0162-package-manager-custom-target-layouts.md

* What is your evaluation of the proposal?

+1

This significantly improves the ability to support a variety of libraries and integrate them without requiring specific project layout changes. It supports continued defaults while allowing variations that are otherwise difficult to support without significant project wrangling.

* Is the problem being addressed significant enough to warrant a change to the Swift Package Manager?

Yes

* Does this proposal fit well with the feel and direction of Swift?

Yes

* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

Review of the proposal during development, along with feedback to the authors.