[Review] SE-0159: Fix Private Access Levels


(Allen Zeng) #1

What is your evaluation of the proposal?

-1.

Plenty of excellent points are made in the threads, which clearly
shows that there are many users who want to use the file based private
feature only, and many users who want to keep everything _really_
private, unless they need to be exposed at a file scope.

For this reason alone, reverting to Swift 2 behaviour is unwise.
Keeping `fileprivate` as is is also a better choice because it very
unambiguously expresses its meaning - a great quality Swift strives
for.

Other reasons that lead me to the decision are the benefits of
encapsulation, churn. Others have made very good arguments already.

Is the problem being addressed significant enough to warrant a change to Swift?

No.

Does this proposal fit well with the feel and direction of Swift?

No.

If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

No other language that I know of behaves this way with the private.
That said, Swift should change things where it makes sense. However I
don't think this proposal is an improvement over how other languages
implement it.

How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

Read all the threads