[Review] SE-0159: Fix Private Access Levels


(Lucas Neiva) #1

I think it's worth simplifying the access levels by removing `fileprivate`. Changing `private` to cover the common file-level cases brings no disadvantages IMO, since there's always the option of moving a declaration to a separate file. (I seem to disagree with a lot of opinions on here, that seem to want more fine grained access level control. I just don't see much tangible benefits, as composing protocols with the current access control levels is enough.)

I wouldn't do the compatibility mode since source conversion seems to work well enough. But I guess source compatibility is a hard goal.

···

---

My main question with all of this: Why is `private` a "soft default"? What's the point of a "soft default"? I think it should be _the_ default. `private` as default would promote encapsulation. It also just seems to make more sense than defining `internal` as the default, which is the "middle one".

On Mar 21, 2017, at 12:55 AM, Douglas Gregor via swift-evolution <swift-evolution@swift.org> wrote:

Hello Swift community,

The review of SE-0159 "Fix Private Access Levels" begins now and runs through March 27, 2017. The proposal is available here:

https://github.com/apple/swift-evolution/blob/master/proposals/0159-fix-private-access-levels.md

Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at

https://lists.swift.org/mailman/listinfo/swift-evolution

or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:

Proposal link:

https://github.com/apple/swift-evolution/blob/master/proposals/0159-fix-private-access-levels.md

Reply text
Other replies
What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:

What is your evaluation of the proposal?
Is the problem being addressed significant enough to warrant a change to Swift?
Does this proposal fit well with the feel and direction of Swift?
If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

More information about the Swift evolution process is available at

https://github.com/apple/swift-evolution/blob/master/process.md

Thank you,

-Doug

Review Manager

_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution


(TJ Usiyan) #2

+1

One less level to explain and not much lost in the shuffle.

···

On Mon, Mar 20, 2017 at 8:44 PM, Lucas Neiva via swift-evolution < swift-evolution@swift.org> wrote:

I think it's worth simplifying the access levels by removing
`fileprivate`. Changing `private` to cover the common file-level cases
brings no disadvantages IMO, since there's always the option of moving a
declaration to a separate file. (I seem to disagree with a lot of opinions
on here, that seem to want more fine grained access level control. I just
don't see much tangible benefits, as composing protocols with the current
access control levels is enough.)

I wouldn't do the compatibility mode since source conversion seems to work
well enough. But I guess source compatibility is a hard goal.

---

My main question with all of this: Why is `private` a "soft default"?
What's the point of a "soft default"? I think it should be _the_ default.
`private` as default would promote encapsulation. It also just seems to
make more sense than defining `internal` as the default, which is the
"middle one".

On Mar 21, 2017, at 12:55 AM, Douglas Gregor via swift-evolution < > swift-evolution@swift.org> wrote:

Hello Swift community,

The review of SE-0159 "Fix Private Access Levels" begins now and runs
through March 27, 2017. The proposal is available here:

https://github.com/apple/swift-evolution/blob/master/
proposals/0159-fix-private-access-levels.md

Reviews are an important part of the Swift evolution process. All reviews
should be sent to the swift-evolution mailing list at

https://lists.swift.org/mailman/listinfo/swift-evolution

or, if you would like to keep your feedback private, directly to the
review manager. When replying, please try to keep the proposal link at the
top of the message:

Proposal link:

https://github.com/apple/swift-evolution/blob/master/
proposals/0159-fix-private-access-levels.md

Reply text

Other replies

<https://github.com/apple/swift-evolution/blob/master/process.md#what-goes-into-a-review-1>What
goes into a review?

The goal of the review process is to improve the proposal under review
through constructive criticism and, eventually, determine the direction of
Swift. When writing your review, here are some questions you might want to
answer in your review:

   - What is your evaluation of the proposal?
   - Is the problem being addressed significant enough to warrant a
   change to Swift?
   - Does this proposal fit well with the feel and direction of Swift?
   - If you have used other languages or libraries with a similar
   feature, how do you feel that this proposal compares to those?
   - How much effort did you put into your review? A glance, a quick
   reading, or an in-depth study?

More information about the Swift evolution process is available at

https://github.com/apple/swift-evolution/blob/master/process.md

Thank you,

-Doug

Review Manager
_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution

_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution