# \[Review\] SE-0146: Package Manager Product Definitions

**URL:** <https://forums.swift.org/t/review-se-0146-package-manager-product-definitions/4540>\
**Category:** Announcements\
**Created:** [November 18, 2016, 12:46am UTC](https://forums.swift.org/t/review-se-0146-package-manager-product-definitions/4540 "2016-11-18T00:46:35Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![ddunbar](https://sea2.discourse-cdn.com/swift/user_avatar/forums.swift.org/ddunbar/32/1933_2.png) [@ddunbar](https://forums.swift.org/u/ddunbar)\
**Post date:** [November 18, 2016, 12:46am UTC](https://forums.swift.org/t/review-se-0146-package-manager-product-definitions/4540/1 "2016-11-18T00:46:35Z")

</div>

Hello Swift community,

The review of "SE-0146: Package Manager Product Definitions" begins now and runs through November 28th. The proposal is available here:

&nbsp;&nbsp;[swift-evolution/0146-package-manager-product-definitions.md at master · apple/swift-evolution · GitHub](https://github.com/apple/swift-evolution/blob/master/proposals/0146-package-manager-product-definitions.md)

Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-build-dev and swift-evolution mailing lists at

&nbsp;&nbsp;[https://lists.swift.org/mailman/listinfo/swift-build-dev](https://lists.swift.org/mailman/listinfo/swift-build-dev)  
&nbsp;&nbsp;[https://lists.swift.org/mailman/listinfo/swift-evolution](https://lists.swift.org/mailman/listinfo/swift-evolution)

or, if you would like to keep your feedback private, directly to the review manager.

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:

&nbsp;&nbsp;\* What is your evaluation of the proposal?  
&nbsp;&nbsp;\* Is the problem being addressed significant enough to warrant a change to Swift?  
&nbsp;&nbsp;\* Does this proposal fit well with the feel and direction of Swift?  
&nbsp;&nbsp;\* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?  
&nbsp;&nbsp;\* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

More information about the Swift evolution process is available at

&nbsp;&nbsp;[swift-evolution/process.md at master · apple/swift-evolution · GitHub](https://github.com/apple/swift-evolution/blob/master/process.md)

Thank you,

Daniel Dunbar  
Review Manager

---

<div class="post-metadata">

**Author:** ![ddunbar](https://sea2.discourse-cdn.com/swift/user_avatar/forums.swift.org/ddunbar/32/1933_2.png) [@ddunbar](https://forums.swift.org/u/ddunbar)\
**Post date:** [November 30, 2016, 5:31pm UTC](https://forums.swift.org/t/review-se-0146-package-manager-product-definitions/4540/2 "2016-11-30T17:31:52Z")

</div>

Proposal Link: [https://github.com/apple/swift-evolution/blob/master/proposals/0146-package-manager-product-definitions.md](https://github.com/apple/swift-evolution/blob/master/proposals/0146-package-manager-product-definitions.md)

The review of "SE-0146: Package Manager Product Definitions" ran from November 18...28. The proposal has been \*accepted\*.

The proposal received no feedback, but as the core team already agreed it is the right direction we will move forward with accepting and implementing it.

Daniel Dunbar  
Review Manager

> **···**
>
> > On Nov 17, 2016, at 4:46 PM, Daniel Dunbar via swift-build-dev \<swift-build-dev@swift.org\> wrote:
> > 
> > Hello Swift community,
> > 
> > The review of "SE-0146: Package Manager Product Definitions" begins now and runs through November 28th. The proposal is available here:
> > 
> > &nbsp;&nbsp;[https://github.com/apple/swift-evolution/blob/master/proposals/0146-package-manager-product-definitions.md](https://github.com/apple/swift-evolution/blob/master/proposals/0146-package-manager-product-definitions.md)
> > 
> > Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-build-dev and swift-evolution mailing lists at
> > 
> > &nbsp;&nbsp;[https://lists.swift.org/mailman/listinfo/swift-build-dev](https://lists.swift.org/mailman/listinfo/swift-build-dev)  
> > &nbsp;&nbsp;[https://lists.swift.org/mailman/listinfo/swift-evolution](https://lists.swift.org/mailman/listinfo/swift-evolution)
> > 
> > or, if you would like to keep your feedback private, directly to the review manager.
> > 
> > What goes into a review?
> > 
> > The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> > 
> > &nbsp;&nbsp;\* What is your evaluation of the proposal?  
> > &nbsp;&nbsp;\* Is the problem being addressed significant enough to warrant a change to Swift?  
> > &nbsp;&nbsp;\* Does this proposal fit well with the feel and direction of Swift?  
> > &nbsp;&nbsp;\* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?  
> > &nbsp;&nbsp;\* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
> > 
> > More information about the Swift evolution process is available at
> > 
> > &nbsp;&nbsp;[https://github.com/apple/swift-evolution/blob/master/process.md](https://github.com/apple/swift-evolution/blob/master/process.md)
> > 
> > Thank you,
> > 
> > Daniel Dunbar  
> > Review Manager
> > 
> > \_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_  
> > swift-build-dev mailing list  
> > swift-build-dev@swift.org  
> > [https://lists.swift.org/mailman/listinfo/swift-build-dev](https://lists.swift.org/mailman/listinfo/swift-build-dev)
