[Review] SE-0137: Avoiding Lock-In to Legacy Protocol Designs


(John McCall) #1

Hello Swift community,

The review of "SE-0137: Avoiding Lock-In to Legacy Protocol Designs" begins now and runs through August 14. The proposal is available here:

  https://github.com/apple/swift-evolution/blob/master/proposals/0137-avoiding-lock-in.md <https://github.com/apple/swift-evolution/blob/master/proposals/0118-closure-parameter-names-and-labels.md>

Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at

  https://lists.swift.org/mailman/listinfo/swift-evolution

or, if you would like to keep your feedback private, directly to the review manager.

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:

  * What is your evaluation of the proposal?
  * Is the problem being addressed significant enough to warrant a change to Swift?
  * Does this proposal fit well with the feel and direction of Swift?
  * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
  * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

More information about the Swift evolution process is available at

  https://github.com/apple/swift-evolution/blob/master/process.md

Thank you,

John McCall
Review Manager


(John McCall) #2

Hello Swift community,

The review of "SE-0137: Avoiding Lock-In to Legacy Protocol Designs" begins now and runs through August 14. The proposal is available here:

  https://github.com/apple/swift-evolution/blob/master/proposals/0137-avoiding-lock-in.md

I'm sorry, this link is incorrect. The right link is:

  https://github.com/apple/swift-evolution/blob/master/proposals/0137-avoiding-lock-in.md

John.

···

On Aug 10, 2016, at 2:03 PM, John McCall via swift-evolution <swift-evolution@swift.org> wrote:

Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at

  https://lists.swift.org/mailman/listinfo/swift-evolution

or, if you would like to keep your feedback private, directly to the review manager.

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:

  * What is your evaluation of the proposal?
  * Is the problem being addressed significant enough to warrant a change to Swift?
  * Does this proposal fit well with the feel and direction of Swift?
  * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
  * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

More information about the Swift evolution process is available at

  https://github.com/apple/swift-evolution/blob/master/process.md

Thank you,

John McCall
Review Manager
_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution


(Brent Royal-Gordon) #3

'ExpressibleByStringInterpolation' is deprecated: it will be replaced or redesigned in Swift 4.0. Instead of conforming to 'ExpressibleByStringInterpolation', consider adding an 'init(_:String)'

I'm not sure I understand this error message. What is the second sentence trying to imply you should do instead of conforming?

Otherwise, +1 to all of this.

···

On Aug 10, 2016, at 2:03 PM, John McCall <rjmccall@apple.com> wrote:

Hello Swift community,

The review of "SE-0137: Avoiding Lock-In to Legacy Protocol Designs" begins now and runs through August 14. The proposal is available here:

  https://github.com/apple/swift-evolution/blob/master/proposals/0137-avoiding-lock-in.md

--
Brent Royal-Gordon
Architechies


(Lily Ballard) #4

* What is your evaluation of the proposal?

+1

* Is the problem being addressed significant enough to warrant a
   change to Swift?

Yes.

* Does this proposal fit well with the feel and direction of Swift?

Yes.

* If you have used other languages or libraries with a similar
   feature, how do you feel that this proposal compares to those?
* How much effort did you put into your review? A glance, a quick
   reading, or an in-depth study?

A quick reading.

-Kevin Ballard

···

On Wed, Aug 10, 2016, at 02:03 PM, John McCall wrote:


(Rod Brown) #5

  * What is your evaluation of the proposal?

+1. Agree we should deprecate legacy features that we don’t intend to support, to make future transitions easier for users.

  * Is the problem being addressed significant enough to warrant a change to Swift?

Yes.

  * Does this proposal fit well with the feel and direction of Swift?

Yes. Consistency and clarity going forward, and clearly documenting the features Swift will not support is important.

  * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

N/A

  * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

Quick Read

···

On 11 Aug 2016, at 7:03 AM, John McCall via swift-evolution <swift-evolution@swift.org> wrote:

Hello Swift community,

The review of "SE-0137: Avoiding Lock-In to Legacy Protocol Designs" begins now and runs through August 14. The proposal is available here:

  https://github.com/apple/swift-evolution/blob/master/proposals/0137-avoiding-lock-in.md <https://github.com/apple/swift-evolution/blob/master/proposals/0118-closure-parameter-names-and-labels.md>

Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at

  https://lists.swift.org/mailman/listinfo/swift-evolution

or, if you would like to keep your feedback private, directly to the review manager.

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:

  * What is your evaluation of the proposal?
  * Is the problem being addressed significant enough to warrant a change to Swift?
  * Does this proposal fit well with the feel and direction of Swift?
  * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
  * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

More information about the Swift evolution process is available at

  https://github.com/apple/swift-evolution/blob/master/process.md

Thank you,

John McCall
Review Manager
_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution


(Dave Abrahams) #6

Hello Swift community,

The review of "SE-0137: Avoiding Lock-In to Legacy Protocol Designs" begins now and runs through August 14. The proposal is available here:

  https://github.com/apple/swift-evolution/blob/master/proposals/0137-avoiding-lock-in.md

  'ExpressibleByStringInterpolation' is deprecated: it will be
replaced or redesigned in Swift 4.0. Instead of conforming to
'ExpressibleByStringInterpolation', consider adding an
'init(_:String)'

I'm not sure I understand this error message. What is the second
sentence trying to imply you should do instead of conforming?

Hmm, I agree that could be clearer. It's trying to say, “just use
string interpolations to express Strings, and give your type a
converting initializer from String.”

···

on Thu Aug 11 2016, Brent Royal-Gordon <swift-evolution@swift.org> wrote:

On Aug 10, 2016, at 2:03 PM, John McCall <rjmccall@apple.com> wrote:

Otherwise, +1 to all of this.

--
-Dave