[Review] SE-0129: Package Manager Test Naming Conventions


(Daniel Dunbar) #1

Hello Swift community,

The review of "SE-0129: Package Manager Test Naming Conventions" begins now and runs through July 26. The proposal is available here:

  https://github.com/apple/swift-evolution/blob/master/proposals/0129-package-manager-test-naming-conventions.md

Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-build-dev and swift-evolution mailing lists at

  https://lists.swift.org/mailman/listinfo/swift-build-dev
  https://lists.swift.org/mailman/listinfo/swift-evolution

or, if you would like to keep your feedback private, directly to the review manager.

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:

  * What is your evaluation of the proposal?
  * Is the problem being addressed significant enough to warrant a change to Swift?
  * Does this proposal fit well with the feel and direction of Swift?
  * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
  * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

More information about the Swift evolution process is available at

  https://github.com/apple/swift-evolution/blob/master/process.md

Thank you,

- Daniel Dunbar
Review Manager

···

_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution


(Ankit Agarwal) #2

        * What is your evaluation of the proposal?

+1 to proposal. This will be a good change to make conventions more clearer
and a step towards supporting test specific libraries.

        * Is the problem being addressed significant enough to warrant a
change to Swift?

Yes, the current convention system for test is confusing and not obvious.

        * Does this proposal fit well with the feel and direction of Swift?

Yes

        * How much effort did you put into your review? A glance, a quick
reading, or an in-depth study?

In depth study

···

--
Ankit


(David Hart) #3

   * What is your evaluation of the proposal?

I really like this proposal as it reduces the surprise factor while continuing to promote convention over configuration. It also mirrors the way people are often would like to name their test modules.

   * Is the problem being addressed significant enough to warrant a change to Swift?

Yes, it's a natural simplification that is fairly forward thinking

   * Does this proposal fit well with the feel and direction of Swift?

Yes.

   * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

No.

   * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

Quick reading.


(TJ Usiyan) #4

* What is your evaluation of the proposal?
+ 1
        * Is the problem being addressed significant enough to warrant a
change to Swift?
Yes
        * Does this proposal fit well with the feel and direction of Swift?
Yes
        * If you have used other languages or libraries with a similar
feature, how do you feel that this proposal compares to those?
It holds up. I would like the ability mentioned in 'Alternatives
Considered' to eventually be implemented.
        * How much effort did you put into your review? A glance, a quick
reading, or an in-depth study?
Quick reading

···

On Fri, Jul 22, 2016 at 1:15 PM, Daniel Dunbar via swift-evolution < swift-evolution@swift.org> wrote:

Hello Swift community,

The review of "SE-0129: Package Manager Test Naming Conventions" begins
now and runs through July 26. The proposal is available here:

https://github.com/apple/swift-evolution/blob/master/proposals/0129-package-manager-test-naming-conventions.md

Reviews are an important part of the Swift evolution process. All reviews
should be sent to the swift-build-dev and swift-evolution mailing lists at

        https://lists.swift.org/mailman/listinfo/swift-build-dev
        https://lists.swift.org/mailman/listinfo/swift-evolution

or, if you would like to keep your feedback private, directly to the
review manager.

What goes into a review?

The goal of the review process is to improve the proposal under review
through constructive criticism and contribute to the direction of Swift.
When writing your review, here are some questions you might want to answer
in your review:

        * What is your evaluation of the proposal?
        * Is the problem being addressed significant enough to warrant a
change to Swift?
        * Does this proposal fit well with the feel and direction of Swift?
        * If you have used other languages or libraries with a similar
feature, how do you feel that this proposal compares to those?
        * How much effort did you put into your review? A glance, a quick
reading, or an in-depth study?

More information about the Swift evolution process is available at

        https://github.com/apple/swift-evolution/blob/master/process.md

Thank you,

- Daniel Dunbar
Review Manager

_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution
_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution