[Review] SE-0124: `Int.init(ObjectIdentifier)` and `UInt.init(ObjectIdentifier)` should have a `bitPattern:` label


(Chris Lattner) #1

Hello Swift community,

The review of "SE-0124: `Int.init(ObjectIdentifier)` and `UInt.init(ObjectIdentifier)` should have a `bitPattern:` label" begins now and runs through July 20. The proposal is available here:

  https://github.com/apple/swift-evolution/blob/master/proposals/0124-bitpattern-label-for-int-initializer-objectidentfier.md

Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at

  https://lists.swift.org/mailman/listinfo/swift-evolution

or, if you would like to keep your feedback private, directly to the review manager.

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:

  * What is your evaluation of the proposal?
  * Is the problem being addressed significant enough to warrant a change to Swift?
  * Does this proposal fit well with the feel and direction of Swift?
  * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
  * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

More information about the Swift evolution process is available at

  https://github.com/apple/swift-evolution/blob/master/process.md

Thank you,

-Chris Lattner
Review Manager


(Jacob Bandes-Storch) #2

        * What is your evaluation of the proposal?

+1

        * Is the problem being addressed significant enough to warrant a
change to Swift?

Yes, minor but important.

        * Does this proposal fit well with the feel and direction of Swift?

Yes, it's consistent with other existing APIs, and it's intuitive.

        * If you have used other languages or libraries with a similar
feature, how do you feel that this proposal compares to those?

N/A

        * How much effort did you put into your review? A glance, a quick
reading, or an in-depth study?

Quick reading of the proposal.


(Hooman Mehr) #3

+1

Same answers.

···

On Jul 15, 2016, at 10:54 PM, Jacob Bandes-Storch via swift-evolution <swift-evolution@swift.org> wrote:

        * What is your evaluation of the proposal?

+1

        * Is the problem being addressed significant enough to warrant a change to Swift?

Yes, minor but important.

        * Does this proposal fit well with the feel and direction of Swift?

Yes, it's consistent with other existing APIs, and it's intuitive.

        * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

N/A

        * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

Quick reading of the proposal.
_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution


(David Rönnqvist) #4

+1. Agreed. A minor but a clear improvement for clarity and consistency.

- David

···

On 16 Jul 2016, at 07:54, Jacob Bandes-Storch via swift-evolution <swift-evolution@swift.org> wrote:

        * What is your evaluation of the proposal?

+1

        * Is the problem being addressed significant enough to warrant a change to Swift?

Yes, minor but important.

        * Does this proposal fit well with the feel and direction of Swift?

Yes, it's consistent with other existing APIs, and it's intuitive.

        * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

N/A

        * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

Quick reading of the proposal.
_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution