[Review] SE-0122: Use colons for subscript declarations


(Davor Jankolija) #1

What is your evaluation of the proposal?

I’m afraid I’m against this proposal, since IMO colons are no better in this case than the arrow syntax.

Is the problem being addressed significant enough to warrant a change to Swift?

I understand that the current syntax isn’t as clear as it possible cold be, but as has been mentioned subscripts are kind of special when it comes to their syntax, so again IMO if anything they should have a totaly different syntax, the :-> syntax sort of makes sense but then again it does look awkward and there’s no predent in the language for it.

Does this proposal fit well with the feel and direction of Swift?

Possibly, but if choosing between the proposed colon syntax and current one, I think Swift should stick to the current one.

How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

I looked really hard at the current syntax and the proposed one :).

Again, I understand why the proposal, just not sure on the colons as a better alternative to what we currently have.

- Davor