Proper way to escalate Swift 6.1 crash blockers

hassila · April 3, 2025, 7:14am

It’s being fixed here for 6.1:

github.com/swiftlang/swift

[6.1][SILOptimizer] Prevent devirtualization of call to distributed witness requirements

release/6.1 ← xedin:rdar-146101172-narrow-6.1

opened 07:00PM - 28 Mar 25 UTC

xedin

+157 -0

Cherry-pick of https://github.com/swiftlang/swift/pull/80373 --- - Explana…tion: Fixes a crash in optimized mode related to use of distributed requirements. This is a narrow fix, we are going to work on fixing this properly and allowing both devirtualization and specialization for distributed requirement witnesses. Anything that uses an ad-hoc serialization requirement scheme cannot be devirtualized because that would result in loss of ad-hoc conformance in new substitution map. - Main Branch PR: https://github.com/swiftlang/swift/pull/80373 - Risk: Very low (narrow fix that only affects uses of witnesses to distributed requirements with ad-hoc serialization requirement). - Resolves: https://github.com/swiftlang/swift/issues/79318 - Resolves: rdar://146101172 - Reviewed By: @slavapestov - Testing: Added new tests to the Distributed test suite. (cherry picked from commit 0415b40a3cea02c7ef7315cd7c7f390686669ccd)

Thanks to @ktoso / @xedin !

hassila · April 3, 2025, 7:16am

(But not sorted why the workaround didn’t work for our package)

ktoso · April 3, 2025, 9:56pm

We'll still have to do a more proper fix, but this will resolve the immediate issue. Thanks for flagging it @hassila