Private type in attribute on public member

Nickolas_Pohilets · 2022-07-07T16:26:05.091Z

I'm surprised that the following code not produce any errors:

@globalActor private final actor PrivateActor {
    static let shared = PrivateActor()
}

public class Foo {
    @PrivateActor public func bar() {}
}

Global actor annotation is part of the function interface, so I would expect it to be required as visible as function itself. Is this a bug?

tshortli · 2022-08-05T17:34:40.813Z

This is definitely a bug. Would you mind logging a Github issue about this?

Nickolas_Pohilets · 2022-08-05T21:06:55.167Z

github.com/apple/swift

Private global actor type can be used to isolated public entities

opened 09:06PM - 05 Aug 22 UTC

closed 02:23AM - 24 Aug 22 UTC

nickolas-pohilets

bug

Consider the following code: ```swift @globalActor private final actor Private…Actor { static let shared = PrivateActor() } public class Foo { @PrivateActor public func bar() {} } ``` It type checks without errors. Global actor annotation is part of the function interface, and escapes into public interface of the module. **Expected behavior** Global actor used for isolation should not be less visible than the entity it is isolating. Given code should produce a compilation error. **Environment (please fill out the following information)** - Xcode 13.3.1, Apple Swift version 5.6 (swiftlang-5.6.0.323.62 clang-1316.0.20.8) - `main` branch, reproducible on https://github.com/apple/swift/commit/a39c78b586155c18fb99e023c5ca42dd6df36145 Radar: rdar://98200658