preset: buildbot_linux_1404/1510 are the same


(Brad Erickson) #1

The [preset: buildbot_linux_1404] is the same as [preset:
buildbot_linux_1510]. 14.04 has a comment stating:

# This preset does not build Foundation due to unavailable ICU versions on
Ubuntu 14.04
src:
https://github.com/apple/swift/blob/469208d9156489c48591d3ffab0560c30c87be54/utils/build-presets.ini#L524

But it actually still builds foundation.

I'm not sure of the correct solution, but either the separate 14.04 preset
can be removed, it shouldn't build foundation, or at least the comment
should be updated. I'm happy to make the fix, but not sure what the
solution is?

-Brad


(Mish Awadah) #2

That’s correct. This comment is out of date.

- mish

···

On Dec 10, 2015, at 10:06 AM, Brad Erickson via swift-dev <swift-dev@swift.org> wrote:

The [preset: buildbot_linux_1404] is the same as [preset: buildbot_linux_1510]. 14.04 has a comment stating:

# This preset does not build Foundation due to unavailable ICU versions on Ubuntu 14.04
src: https://github.com/apple/swift/blob/469208d9156489c48591d3ffab0560c30c87be54/utils/build-presets.ini#L524

But it actually still builds foundation.

I'm not sure of the correct solution, but either the separate 14.04 preset can be removed, it shouldn't build foundation, or at least the comment should be updated. I'm happy to make the fix, but not sure what the solution is?

-Brad
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev


(Brad Erickson) #3

The best solution is to remove one and rename the other simply: [preset:
buildbot_linux], but that will have far reaching effects. Nothing that
can't be dealt with though. How should this be handled?

-Brad

···

On Thu, Dec 10, 2015 at 10:24 AM, Mish Awadah <mawadah@apple.com> wrote:

That’s correct. This comment is out of date.

- mish

On Dec 10, 2015, at 10:06 AM, Brad Erickson via swift-dev < > swift-dev@swift.org> wrote:

The [preset: buildbot_linux_1404] is the same as [preset:
buildbot_linux_1510]. 14.04 has a comment stating:

# This preset does not build Foundation due to unavailable ICU versions on
Ubuntu 14.04
src:
https://github.com/apple/swift/blob/469208d9156489c48591d3ffab0560c30c87be54/utils/build-presets.ini#L524

But it actually still builds foundation.

I'm not sure of the correct solution, but either the separate 14.04 preset
can be removed, it shouldn't build foundation, or at least the comment
should be updated. I'm happy to make the fix, but not sure what the
solution is?

-Brad
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev


(Dmitri Gribenko) #4

The best solution is to sink all common parts into buildbot_linux, and
keep buildbot_linux_* presets for emergency customization like that,
if it would be required in future.

Please submit a pull request, if you would like to work on this.

Dmitri

···

On Thu, Dec 10, 2015 at 10:33 AM, Brad Erickson via swift-dev <swift-dev@swift.org> wrote:

The best solution is to remove one and rename the other simply: [preset: buildbot_linux], but that will have far reaching effects. Nothing that can't be dealt with though. How should this be handled?

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com>*/


(Brad Erickson) #5

Totally reasonable. I'll take care of it.

-Brad Erickson

···

On Thu, Dec 10, 2015 at 10:53 AM, Dmitri Gribenko <gribozavr@gmail.com> wrote:

On Thu, Dec 10, 2015 at 10:33 AM, Brad Erickson via swift-dev > <swift-dev@swift.org> wrote:
>
> The best solution is to remove one and rename the other simply: [preset:
buildbot_linux], but that will have far reaching effects. Nothing that
can't be dealt with though. How should this be handled?

The best solution is to sink all common parts into buildbot_linux, and
keep buildbot_linux_* presets for emergency customization like that,
if it would be required in future.

Please submit a pull request, if you would like to work on this.

Dmitri

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com>*/


(Brad Erickson) #6

Done: https://github.com/apple/swift/pull/403

-Brad Erickson

···

On Thu, Dec 10, 2015 at 11:24 AM, Brad Erickson <brad@eosrei.net> wrote:

Totally reasonable. I'll take care of it.

-Brad Erickson

On Thu, Dec 10, 2015 at 10:53 AM, Dmitri Gribenko <gribozavr@gmail.com> > wrote:

On Thu, Dec 10, 2015 at 10:33 AM, Brad Erickson via swift-dev >> <swift-dev@swift.org> wrote:
>
> The best solution is to remove one and rename the other simply:
[preset: buildbot_linux], but that will have far reaching effects. Nothing
that can't be dealt with though. How should this be handled?

The best solution is to sink all common parts into buildbot_linux, and
keep buildbot_linux_* presets for emergency customization like that,
if it would be required in future.

Please submit a pull request, if you would like to work on this.

Dmitri

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com>*/