PR review process


(Pavol Vaskovic) #1

Hello!

What is the process for getting a PR reviewed and merged into Swift? My
experience so far is inconsistent. Sometimes I get a response in a few
hours, discussion starts and I know I'm not wasting effort. At the moment I
have 2 PRs open. One for 8 days without response.

I understand that Apple folks are pretty busy before WWDC…

I was told that I should be patient and wait a week before asking for a
review again.

Is there a way to improve upon the current state of affairs?

Best regards
Pavol Vaskovic


(Slava Pestov) #2

Hi Pavol,

Bug us mercilessly if you need something reviewed.

Slava

···

On May 4, 2017, at 9:26 AM, Pavol Vaskovic via swift-dev <swift-dev@swift.org> wrote:

Hello!

What is the process for getting a PR reviewed and merged into Swift? My experience so far is inconsistent. Sometimes I get a response in a few hours, discussion starts and I know I'm not wasting effort. At the moment I have 2 PRs open. One for 8 days without response.

I understand that Apple folks are pretty busy before WWDC…

I was told that I should be patient and wait a week before asking for a review again.

Is there a way to improve upon the current state of affairs?

Best regards
Pavol Vaskovic
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev


(Slava Pestov) #3

I found three PRs from you and looked at two. I’m fine with merging them once the tests pass so I assigned them to myself as a reminder.

I’m assuming this one is not ready yet though: https://github.com/apple/swift/pull/8793

Slava

···

On May 4, 2017, at 2:40 PM, Slava Pestov via swift-dev <swift-dev@swift.org> wrote:

Hi Pavol,

Bug us mercilessly if you need something reviewed.

Slava

On May 4, 2017, at 9:26 AM, Pavol Vaskovic via swift-dev <swift-dev@swift.org> wrote:

Hello!

What is the process for getting a PR reviewed and merged into Swift? My experience so far is inconsistent. Sometimes I get a response in a few hours, discussion starts and I know I'm not wasting effort. At the moment I have 2 PRs open. One for 8 days without response.

I understand that Apple folks are pretty busy before WWDC…

I was told that I should be patient and wait a week before asking for a review again.

Is there a way to improve upon the current state of affairs?

Best regards
Pavol Vaskovic
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev