I am currently preparing to implement Proposal to change the default ownership for passing parameters and enable the convention change on master. I have been thinking about the least disruptive way to do this transition since
it is a big one. The main minimization points I thought about were build
breakage and impact on other developers. With that in mind my goals are:
- To other developers, there should be minimal impact on their workflow. That
means making the disruption time as small as possible.
- The build should be repairable without having to churn the tests. There needs
to be a simple, small commit that can undo this in case of crazy breakage.
With that in mind here is the plan:
I am going to commit all of the changed tests with a prefix of some
sort. These will not run when normal people are developing since they will be
protected by the plus_zero_runtime lit feature. In addition, I will update
the non-prefixed tests to be guarded by the plus_one_runtime lit
feature. This is important since otherwise, I can not make a small revert
without touching those 200 tests.
On my branch (#14953), I am going to keep the updated tests in both positions
(with and without the prefix). This will let me as people change tests to be
able to still detect conflicts. I have written some scripting that takes the
current tests in that branch, copies them into their PREFIX form on
master. So I can continue to update these tests without any impacts on other
Once everything is ready, I should be able to do a small commit that flips
the switch everywhere. At this point, other developers will have an impact
namely that they need to update the ~200 plus zero tests instead of the
normal tests. I imagine that this will only be so that we can do a quick
revert if there are problems and will not last more than a couple of days if
Once this is done and all the dust has settled, then we just move over the
plus zero tests to their new home.
The time table for this work is:
- 3/9-3/11. I would like to get to stage 3 by this weekend.
- 3/12-3/15. I am going to fix any issues that come up over the week.
- 3/16-3/18. Sometime over next weekend, I would like to do stage 4.
I will post to this thread when I perform each one of these individual tasks.