@lorentey I didn't follow along too closely with the Span
review while it was taking place… but I just went back and searched through the pitches and reviews and I did not see a mention of the isIdentical
function being discussed. Do you remember if there were any offline discussions about why this function should be named isIdentical
? Were there any offline discussions about a potential mustBeEqual
function instead?
Hmm… so the thinking here is we could go ahead and ship public isIdentical
implementations on the appropriate standard library and Foundation types and then ship a potential Distinguishable
protocol somewhere like swift-collections
? And when a product engineer depends on swift-collections
they get the Distinguishable
protocol available for their own types as well as the adopting on types like Array
and TreeDictionary
?
I do believe there are legit generic context use-cases inside the standard library for us to optimize if Distinguishable
shipped in there. It would be impactful to ship them sooner rather than later. I guess if we did ship in swift-collections
and then incubate for one Swift release cycle that would put us about another six months in the future?