NSString.isAbsolutePath inconsistency


(Nethra Ravindran) #1

Hi Philippe,

A naming inconsistency with NSString.isAbsolutePath (file -
NSPathUtilities.swift) was fixed in your PR named “ Import CoreFoundation
changes from Sierra “:

https://github.com/apple/swift-corelibs-foundation/commit/a455cde38e06052385560d0a7c5aeb5a4991f844

However it appears that this PR hasn’t been cherry picked for
swift-3.1-branch. I wanted to check if you plan to cherry-pick this PR for
3.1. If not I can raise a PR only for the NSString.isAbsolutePath
inconsistency on the 3.1 branch.

Please let me know what you think.

Thank you.

-Nethra Ravindran


(Tony Parker) #2

Hi Nethra,

If this was in master sometime before this past Tuesday, it should be included in the swift-3.1 branch by default (that branch received merges from master).

Did you check out the latest version of the swift-3.1 branch to verify that this change was missing?

- Tony

···

On Jan 19, 2017, at 4:23 AM, Nethra Ravindran via swift-corelibs-dev <swift-corelibs-dev@swift.org> wrote:

Hi Philippe,

A naming inconsistency with NSString.isAbsolutePath (file - NSPathUtilities.swift) was fixed in your PR named “ Import CoreFoundation changes from Sierra “:

https://github.com/apple/swift-corelibs-foundation/commit/a455cde38e06052385560d0a7c5aeb5a4991f844

However it appears that this PR hasn’t been cherry picked for swift-3.1-branch. I wanted to check if you plan to cherry-pick this PR for 3.1. If not I can raise a PR only for the NSString.isAbsolutePath inconsistency on the 3.1 branch.

Please let me know what you think.

Thank you.

-Nethra Ravindran
_______________________________________________
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev


(Nethra Ravindran) #3

Hi Tony and Philippe,

I can now see that it is available in swift-3.1 branch. Sorry for the
confusion.
- Nethra Ravindran

···

On Fri, Jan 20, 2017 at 3:53 AM, Tony Parker <anthony.parker@apple.com> wrote:

Hi Nethra,

If this was in master sometime before this past Tuesday, it should be
included in the swift-3.1 branch by default (that branch received merges
from master).

Did you check out the latest version of the swift-3.1 branch to verify
that this change was missing?

- Tony

On Jan 19, 2017, at 4:23 AM, Nethra Ravindran via swift-corelibs-dev < > swift-corelibs-dev@swift.org> wrote:

Hi Philippe,

A naming inconsistency with NSString.isAbsolutePath (file -
NSPathUtilities.swift) was fixed in your PR named “ Import CoreFoundation
changes from Sierra “:

https://github.com/apple/swift-corelibs-foundation/commit/
a455cde38e06052385560d0a7c5aeb5a4991f844

However it appears that this PR hasn’t been cherry picked for
swift-3.1-branch. I wanted to check if you plan to cherry-pick this PR for
3.1. If not I can raise a PR only for the NSString.isAbsolutePath
inconsistency on the 3.1 branch.

Please let me know what you think.

Thank you.

-Nethra Ravindran
_______________________________________________
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev