Is swift.org/contributing/ stale?

On the swift.org/contributing/ web page, under “Commit Access”, the section talks about commit access in a way that suggests that it was written before mandatory continuous integration testing was added. Is this true? Can somebody update the page? If CI is not required, then is there something I need to do before pushing a commit?

Thanks!
Dave

I think it’s still up to date. You need commit access to trigger CI, and to merge PRs. Otherwise you’ll have to ask someone with commit access to do that for you.

Slava

···

On Aug 14, 2017, at 1:14 PM, David Zarzycki via swift-dev <swift-dev@swift.org> wrote:

On the swift.org/contributing/ web page, under “Commit Access”, the section talks about commit access in a way that suggests that it was written before mandatory continuous integration testing was added. Is this true? Can somebody update the page? If CI is not required, then is there something I need to do before pushing a commit?

Thanks!
Dave
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Hi Slava,

Ah. So “GitHub collaborator” status doesn’t imply commit access then?

Dave

···

On Aug 14, 2017, at 13:22, Slava Pestov <spestov@apple.com> wrote:

I think it’s still up to date. You need commit access to trigger CI, and to merge PRs. Otherwise you’ll have to ask someone with commit access to do that for you.

Slava

On Aug 14, 2017, at 1:14 PM, David Zarzycki via swift-dev <swift-dev@swift.org> wrote:

On the swift.org/contributing/ web page, under “Commit Access”, the section talks about commit access in a way that suggests that it was written before mandatory continuous integration testing was added. Is this true? Can somebody update the page? If CI is not required, then is there something I need to do before pushing a commit?

Thanks!
Dave
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Hi Slava,

Ah. So “GitHub collaborator” status doesn’t imply commit access then?

I think that only means that you have a commit in the repository, nothing more. But my memory might be wrong.

···

On Aug 14, 2017, at 10:32 AM, David Zarzycki via swift-dev <swift-dev@swift.org> wrote:

Dave

On Aug 14, 2017, at 13:22, Slava Pestov <spestov@apple.com> wrote:

I think it’s still up to date. You need commit access to trigger CI, and to merge PRs. Otherwise you’ll have to ask someone with commit access to do that for you.

Slava

On Aug 14, 2017, at 1:14 PM, David Zarzycki via swift-dev <swift-dev@swift.org> wrote:

On the swift.org/contributing/ web page, under “Commit Access”, the section talks about commit access in a way that suggests that it was written before mandatory continuous integration testing was added. Is this true? Can somebody update the page? If CI is not required, then is there something I need to do before pushing a commit?

Thanks!
Dave
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Hi Slava,

Ah. So “GitHub collaborator” status doesn’t imply commit access then?

I think that only means that you have a commit in the repository, nothing more. But my memory might be wrong.

Yes, GitHub automatically attaches this tag to anybody who has at least one commit: it isn’t a tag assigned by the Swift Open Source project.

···

On 14 Aug 2017, at 19:50, Michael Gottesman via swift-dev <swift-dev@swift.org> wrote:

On Aug 14, 2017, at 10:32 AM, David Zarzycki via swift-dev <swift-dev@swift.org> wrote:

Dave

On Aug 14, 2017, at 13:22, Slava Pestov <spestov@apple.com> wrote:

I think it’s still up to date. You need commit access to trigger CI, and to merge PRs. Otherwise you’ll have to ask someone with commit access to do that for you.

Slava

On Aug 14, 2017, at 1:14 PM, David Zarzycki via swift-dev <swift-dev@swift.org> wrote:

On the swift.org/contributing/ web page, under “Commit Access”, the section talks about commit access in a way that suggests that it was written before mandatory continuous integration testing was added. Is this true? Can somebody update the page? If CI is not required, then is there something I need to do before pushing a commit?

Thanks!
Dave
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev