How to disable logging with os_log

krzyzanowskim · January 11, 2019, 8:39pm

When os_log is used, sourcekit-lsp logs everything (guess that's expected)

apple/sourcekit-lsp/blob/e6abaf00aef5535452f7e8f97a15863fdb406629/Sources/SKSupport/Logging.swift#L133


      
            }
          
          
  public func log(_ message: String, level: LogLevel, async: Bool = true) {
          
          
    let currentLevel = self.currentLevel
          
          
    var usedOSLog = false
          #if canImport(os)
              if !disableOSLog, #available(OSX 10.12, *) {
                // If os_log is available, we call it unconditionally since it has its own log-level handling that we respect.
                os_log("%@", type: level.osLogType, message)
                usedOSLog = true
              }
          #endif
          
          
    if level > currentLevel {
                return
              }
          
          
    let logImpl = { self.logImpl(message, level: level, usedOSLog: usedOSLog) }

I'm not fluent in os_log setup (looking at macOS and Xcode). Is there a way to disable logs when spawning the sourcekit-lsp process? it all goes to the Xcode console and is super annoying ;P

PS. I know Tests uses Logger.disableOSLog to disable logs completely (I guess because it was too verbose in console)

Josh_Wisenbaker · January 11, 2019, 9:28pm

While you can adjust the levels some via profiles or the log command, I don't know that you can totally disable the default levels easily with os_log.

In that class disableOSLog is a bool that defaults to false. Is sourcekit-lsp looking for an environment variable or something when you run it to know if it should set that flag on the Logger class?

blangmuir · January 11, 2019, 9:38pm

The disableOSLog flag is only ever set to true during one specific test today, but patches welcome for making it configurable.

Sorry, I don't know off hand if it's possible to turn it off globally during Xcode debugging - I believe os_log behaves specially when running under the debugger, but I assume the configuration options @Josh_Wisenbaker mentioned would still apply.

krzyzanowskim · January 11, 2019, 10:07pm

thanks. Noticed that, but it looks very cumbersome and system level, that why I asked.

shouldn't "os_log" specify "com.apple.sourcekit-lsp" or something like that to make it possible to filter it out with the "subsystems" ?