Foundation and explicit pointer nullability (CI edition)


(Jordan Rose) #1

Hi, swift-corelibs-dev. I'm planning to land the changes for SE-0055: Making pointer nullability explicit <https://github.com/apple/swift-evolution/blob/master/proposals/0055-optional-unsafe-pointers.md> this afternoon in the Swift compiler; however, the corresponding diff for Foundation is fairly large (PR #304 <https://github.com/apple/swift-corelibs-foundation/pull/304>). Because of this, we've decided to hold off on migrating Foundation to the new model for UnsafePointer, so that it can be reviewed at leisure. This means that for a period of time, swift-corelibs-foundation will not build against the 'master' branch of the compiler. Instead, we're going to make a branch today that's passed all the CI checks, and use that for regression-testing (and building) Foundation for now.

Mishal, Jacob, or I will send a follow-up email once the compiler branch has been created, and another once CI has been updated.

Jordan


(Jordan Rose) #2

Update: we've created the master-before-optional-pointers branch at ff373e9, but run into some complications putting this plan into action. (Specifically, I forgot that SwiftPM depends on XCTest for its test cases, and that XCTest of course depends on Foundation.) I'll send another message tomorrow with any new developments.

Jordan

···

On Apr 11, 2016, at 12:23 , Jordan Rose via swift-corelibs-dev <swift-corelibs-dev@swift.org> wrote:

Hi, swift-corelibs-dev. I'm planning to land the changes for SE-0055: Making pointer nullability explicit <https://github.com/apple/swift-evolution/blob/master/proposals/0055-optional-unsafe-pointers.md> this afternoon in the Swift compiler; however, the corresponding diff for Foundation is fairly large (PR #304 <https://github.com/apple/swift-corelibs-foundation/pull/304>). Because of this, we've decided to hold off on migrating Foundation to the new model for UnsafePointer, so that it can be reviewed at leisure. This means that for a period of time, swift-corelibs-foundation will not build against the 'master' branch of the compiler. Instead, we're going to make a branch today that's passed all the CI checks, and use that for regression-testing (and building) Foundation for now.

Mishal, Jacob, or I will send a follow-up email once the compiler branch has been created, and another once CI has been updated.

Jordan

_______________________________________________
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev


(Jordan Rose) #3

Final update: we decided it was cleaner to just update Foundation now rather than building with a separate branch and having to work out those dependencies, so essentially nothing will change. The pull request has been landed but is still planned to have a full post-commit review at a later date.

Apologies for all the confusion!
Jordan

···

On Apr 11, 2016, at 20:56 , Jordan Rose via swift-corelibs-dev <swift-corelibs-dev@swift.org> wrote:

Update: we've created the master-before-optional-pointers branch at ff373e9, but run into some complications putting this plan into action. (Specifically, I forgot that SwiftPM depends on XCTest for its test cases, and that XCTest of course depends on Foundation.) I'll send another message tomorrow with any new developments.

Jordan

On Apr 11, 2016, at 12:23 , Jordan Rose via swift-corelibs-dev <swift-corelibs-dev@swift.org <mailto:swift-corelibs-dev@swift.org>> wrote:

Hi, swift-corelibs-dev. I'm planning to land the changes for SE-0055: Making pointer nullability explicit <https://github.com/apple/swift-evolution/blob/master/proposals/0055-optional-unsafe-pointers.md> this afternoon in the Swift compiler; however, the corresponding diff for Foundation is fairly large (PR #304 <https://github.com/apple/swift-corelibs-foundation/pull/304>). Because of this, we've decided to hold off on migrating Foundation to the new model for UnsafePointer, so that it can be reviewed at leisure. This means that for a period of time, swift-corelibs-foundation will not build against the 'master' branch of the compiler. Instead, we're going to make a branch today that's passed all the CI checks, and use that for regression-testing (and building) Foundation for now.

Mishal, Jacob, or I will send a follow-up email once the compiler branch has been created, and another once CI has been updated.

Jordan

_______________________________________________
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org <mailto:swift-corelibs-dev@swift.org>
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

_______________________________________________
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev