Even and Odd Integers

[xwu (Xiaodi Wu)]

@Jens

My point was that testing for oddness by writing x % 2 == 1 rather than x % 2 != 0 makes it look like the author has an incomplete understanding of the semantics of % , and should be considered bad practice (even in cases where x would only ever be positive).

x % 2 == 1 tests that x is both positive and odd all in one go, which is entirely legitimate when the only expected inputs are positive. In no way is such testing of one's assumptions (for free, performance-wise!) bad practice.