CI trigger request

jtbandes · 2016-07-21T20:08:16.000Z

Could someone kindly trigger CI again for me?

github.com/apple/swift

[stdlib] Remove optional comparison operators (SE-0121)

apple:master ← jtbandes:se-0121

opened 07:28PM - 20 Jul 16 UTC

jtbandes

+13 -53

#### What's in this pull request? An "implementation" (it's pretty much just …deleting code) of [SE-0121](https://github.com/apple/swift-evolution/blob/master/proposals/0121-remove-optional-comparison-operators.md): removing the versions of `<`, `<=`, `>`, and `>=` which accept Optional operands. --- Before merging this pull request to apple/swift repository: - [x] Test pull request on Swift continuous integration. <details> <summary> Triggering Swift CI</summary> The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are: **Smoke Testing** | Platform | Comment | | --- | --- | | All supported platforms | @swift-ci Please smoke test | | All supported platforms | @swift-ci Please smoke test and merge | | OS X platform | @swift-ci Please smoke test OS X platform | | Linux platform | @swift-ci Please smoke test Linux platform | A smoke test on macOS does the following: 1. Builds the compiler incrementally. 2. Builds the standard library only for macOS. Simulator standard libraries and device standard libraries are not built. 3. lldb is not built. 4. The test and validation-test targets are run only for macOS. The optimized version of these tests are not run. A smoke test on Linux does the following: 1. Builds the compiler incrementally. 2. Builds the standard library incrementally. 3. lldb is built incrementally. 4. The swift test and validation-test targets are run. The optimized version of these tests are not run. 5. lldb is tested. **Validation Testing** | Platform | Comment | | --- | --- | | All supported platforms | @swift-ci Please test | | All supported platforms | @swift-ci Please test and merge | | OS X platform | @swift-ci Please test OS X platform | | OS X platform | @swift-ci Please benchmark | | Linux platform | @swift-ci Please test Linux platform | **Lint Testing** | Language | Comment | | --- | --- | | Python | @swift-ci Please Python lint | Note: Only members of the Apple organization can trigger swift-ci. </details>

Jacob

Tony_Parker · 2016-07-21T20:15:40.000Z

I kicked it off.

- Tony

···

On Jul 21, 2016, at 1:08 PM, Jacob Bandes-Storch via swift-dev <swift-dev@swift.org> wrote:

Could someone kindly trigger CI again for me? [stdlib] Remove optional comparison operators (SE-0121) by jtbandes · Pull Request #3637 · apple/swift · GitHub

Jacob
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

jtbandes · 2016-07-21T21:45:35.000Z

Is there something special I need to do to make CI automatically use the
latest commits from swift-package-manager and swift-corelibs-foundation?
The SwiftPM build seemed to fail again with the same error it had the first
time: https://ci.swift.org/job/swift-PR-osx/2642/console But I already
fixed this in [SE-0121] remove usage of optional < operator by jtbandes · Pull Request #515 · apple/swift-package-manager · GitHub

Jacob

···

On Thu, Jul 21, 2016 at 1:15 PM, Tony Parker <anthony.parker@apple.com> wrote:

I kicked it off.

- Tony

On Jul 21, 2016, at 1:08 PM, Jacob Bandes-Storch via swift-dev < > swift-dev@swift.org> wrote:

Could someone kindly trigger CI again for me?
[stdlib] Remove optional comparison operators (SE-0121) by jtbandes · Pull Request #3637 · apple/swift · GitHub

Jacob
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

jtbandes · 2016-07-21T21:47:04.000Z

Just kidding, this is another instance of the same error. Will require a
separate fix.

···

On Thu, Jul 21, 2016 at 2:45 PM, Jacob Bandes-Storch <jtbandes@gmail.com> wrote:

Is there something special I need to do to make CI automatically use the
latest commits from swift-package-manager and swift-corelibs-foundation?
The SwiftPM build seemed to fail again with the same error it had the first
time: https://ci.swift.org/job/swift-PR-osx/2642/console But I already
fixed this in [SE-0121] remove usage of optional < operator by jtbandes · Pull Request #515 · apple/swift-package-manager · GitHub

Jacob

On Thu, Jul 21, 2016 at 1:15 PM, Tony Parker <anthony.parker@apple.com> > wrote:

I kicked it off.

- Tony

On Jul 21, 2016, at 1:08 PM, Jacob Bandes-Storch via swift-dev < >> swift-dev@swift.org> wrote:

Could someone kindly trigger CI again for me?
[stdlib] Remove optional comparison operators (SE-0121) by jtbandes · Pull Request #3637 · apple/swift · GitHub

Jacob
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

jtbandes · 2016-07-21T23:16:48.000Z

Next, could someone take care of
[SE-0121] remove more uses of optional < operator by jtbandes · Pull Request #519 · apple/swift-package-manager · GitHub ?

Thanks in advance,
Jacob

···

On Thu, Jul 21, 2016 at 2:47 PM, Jacob Bandes-Storch <jtbandes@gmail.com> wrote:

Just kidding, this is another instance of the same error. Will require a
separate fix.

On Thu, Jul 21, 2016 at 2:45 PM, Jacob Bandes-Storch <jtbandes@gmail.com> > wrote:

Is there something special I need to do to make CI automatically use the
latest commits from swift-package-manager and swift-corelibs-foundation?
The SwiftPM build seemed to fail again with the same error it had the first
time: https://ci.swift.org/job/swift-PR-osx/2642/console But I already
fixed this in [SE-0121] remove usage of optional < operator by jtbandes · Pull Request #515 · apple/swift-package-manager · GitHub

Jacob

On Thu, Jul 21, 2016 at 1:15 PM, Tony Parker <anthony.parker@apple.com> >> wrote:

I kicked it off.

- Tony

On Jul 21, 2016, at 1:08 PM, Jacob Bandes-Storch via swift-dev < >>> swift-dev@swift.org> wrote:

Could someone kindly trigger CI again for me?
[stdlib] Remove optional comparison operators (SE-0121) by jtbandes · Pull Request #3637 · apple/swift · GitHub

Jacob
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

jtbandes · 2016-07-23T21:01:41.000Z

At this point I believe merging corelibs-foundation#464
<https://github.com/apple/swift-corelibs-foundation/pull/464> is the last
change remaining for swift#3637 <https://github.com/apple/swift/pull/3637> to
build/test/merge successfully.

Jacob

···

On Thu, Jul 21, 2016 at 4:16 PM, Jacob Bandes-Storch <jtbandes@gmail.com> wrote:

Next, could someone take care of
[SE-0121] remove more uses of optional < operator by jtbandes · Pull Request #519 · apple/swift-package-manager · GitHub ?

Thanks in advance,
Jacob

On Thu, Jul 21, 2016 at 2:47 PM, Jacob Bandes-Storch <jtbandes@gmail.com> > wrote:

Just kidding, this is another instance of the same error. Will require a
separate fix.

On Thu, Jul 21, 2016 at 2:45 PM, Jacob Bandes-Storch <jtbandes@gmail.com> >> wrote:

Is there something special I need to do to make CI automatically use the
latest commits from swift-package-manager and swift-corelibs-foundation?
The SwiftPM build seemed to fail again with the same error it had the first
time: https://ci.swift.org/job/swift-PR-osx/2642/console But I
already fixed this in
[SE-0121] remove usage of optional < operator by jtbandes · Pull Request #515 · apple/swift-package-manager · GitHub

Jacob

On Thu, Jul 21, 2016 at 1:15 PM, Tony Parker <anthony.parker@apple.com> >>> wrote:

I kicked it off.

- Tony

On Jul 21, 2016, at 1:08 PM, Jacob Bandes-Storch via swift-dev < >>>> swift-dev@swift.org> wrote:

Could someone kindly trigger CI again for me?
[stdlib] Remove optional comparison operators (SE-0121) by jtbandes · Pull Request #3637 · apple/swift · GitHub

Jacob
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev