Build failure in LLDB


(Joe Bell) #1

Good morning and Happy New Year.

All repos updated with ./swift/utils/update-checkout --all as of 10AM
Central, and getting a compile failure on:

lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:146:79:
error: no member named 'getBodyParamPatterns' in 'swift::FuncDecl'
        llvm::MutableArrayRef<swift::Pattern *> lhs_patterns =
lhs_func_decl->getBodyParamPatterns();

I see a number of commits going into swift repo at the moment, can anyone
confirm rebuilding lldb against it?

Joe


(Joe Bell) #2

I've confirmed that the lldb failure is with a pristine build environment
as well:

lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:146:79:
error: no member named 'getBodyParamPatterns' in 'swift::FuncDecl'
        llvm::MutableArrayRef<swift::Pattern *> lhs_patterns =
lhs_func_decl->getBodyParamPatterns();

~~~~~~~~~~~~~ ^

···

On Fri, Jan 1, 2016 at 10:55 AM, Joseph Bell <joe@iachieved.it> wrote:

Good morning and Happy New Year.

All repos updated with ./swift/utils/update-checkout --all as of 10AM
Central, and getting a compile failure on:

lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:146:79:
error: no member named 'getBodyParamPatterns' in 'swift::FuncDecl'
        llvm::MutableArrayRef<swift::Pattern *> lhs_patterns =
lhs_func_decl->getBodyParamPatterns();

I see a number of commits going into swift repo at the moment, can anyone
confirm rebuilding lldb against it?

Joe


(Chris Lattner) #3

My fault, I think that ea61c8a should fix it, but I haven’t tested it. Can you please let me know if there is still a problem?

Thanks!

-Chris

···

On Jan 1, 2016, at 10:46 AM, Joseph Bell via swift-dev <swift-dev@swift.org> wrote:

I've confirmed that the lldb failure is with a pristine build environment as well:

lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:146:79: error: no member named 'getBodyParamPatterns' in 'swift::FuncDecl'
        llvm::MutableArrayRef<swift::Pattern *> lhs_patterns = lhs_func_decl->getBodyParamPatterns();
                                                               ~~~~~~~~~~~~~ ^

On Fri, Jan 1, 2016 at 10:55 AM, Joseph Bell <joe@iachieved.it <mailto:joe@iachieved.it>> wrote:
Good morning and Happy New Year.

All repos updated with ./swift/utils/update-checkout --all as of 10AM Central, and getting a compile failure on:

lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:146:79: error: no member named 'getBodyParamPatterns' in 'swift::FuncDecl'
        llvm::MutableArrayRef<swift::Pattern *> lhs_patterns = lhs_func_decl->getBodyParamPatterns();

I see a number of commits going into swift repo at the moment, can anyone confirm rebuilding lldb against it?

Joe

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev


(Joe Bell) #4

Chris:

One error down, a few more:
/lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:155:47:
error: member reference type 'llvm::MutableArrayRef<swift::ParameterList
*>' is not a pointer; maybe you meant to use '.'?
                auto *lhs_param = lhs_patterns->get(idx);
                                  ~~~~~~~~~~~~^~
                                              .
lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:155:49:
error: no member named 'get' in 'llvm::MutableArrayRef<swift::ParameterList
*>'
                auto *lhs_param = lhs_patterns->get(idx);
                                  ~~~~~~~~~~~~ ^
lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:156:47:
error: member reference type 'llvm::MutableArrayRef<swift::ParameterList
*>' is not a pointer; maybe you meant to use '.'?
                auto *rhs_param = rhs_patterns->get(idx);
                                  ~~~~~~~~~~~~^~
                                              .
lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:156:49:
error: no member named 'get' in 'llvm::MutableArrayRef<swift::ParameterList
*>'
                auto *rhs_param = rhs_patterns->get(idx);
                                  ~~~~~~~~~~~~ ^
4 errors generated.

followed by

lldb/source/Plugins/ExpressionParser/Swift/SwiftASTManipulator.cpp:1486:28:
error: cannot use incomplete type 'swift::ParameterList' as a range
        for (auto &param : *paramList)
                           ^
swift/include/swift/AST/Identifier.h:30:9: note: forward declaration of
'swift::ParameterList'
  class ParameterList;
        ^
lldb/source/Plugins/ExpressionParser/Swift/SwiftASTManipulator.cpp:1487:36:
error: use of undeclared identifier 'm_name'
            if (param.getName() == m_name)
                                   ^
2 errors generated.

This is with

cd lldb && git rev-parse HEAD
ea61c8a73a4eb6c818467bc497c83c125c697c9c

Thanks,
Joe

···

On Fri, Jan 1, 2016 at 1:15 PM, Chris Lattner <clattner@apple.com> wrote:

My fault, I think that ea61c8a should fix it, but I haven’t tested it.
Can you please let me know if there is still a problem?

Thanks!

-Chris

On Jan 1, 2016, at 10:46 AM, Joseph Bell via swift-dev < > swift-dev@swift.org> wrote:

I've confirmed that the lldb failure is with a pristine build environment
as well:

lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:146:79:
error: no member named 'getBodyParamPatterns' in 'swift::FuncDecl'
        llvm::MutableArrayRef<swift::Pattern *> lhs_patterns =
lhs_func_decl->getBodyParamPatterns();

~~~~~~~~~~~~~ ^

On Fri, Jan 1, 2016 at 10:55 AM, Joseph Bell <joe@iachieved.it> wrote:

Good morning and Happy New Year.

All repos updated with ./swift/utils/update-checkout --all as of 10AM
Central, and getting a compile failure on:

lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:146:79:
error: no member named 'getBodyParamPatterns' in 'swift::FuncDecl'
        llvm::MutableArrayRef<swift::Pattern *> lhs_patterns =
lhs_func_decl->getBodyParamPatterns();

I see a number of commits going into swift repo at the moment, can anyone
confirm rebuilding lldb against it?

Joe

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev


(Joe Bell) #5

Confirmed that as of the following revs the world builds and all tests
passing:

% swift swiftrevs.swift
swift:c264b1eda0d
llvm:3ebdbb2c7e5
clang:f66c5bb67b9
lldb:37fa5a942ff
cmark:5af77f3c1d7
llbuild:7fba6e6213e
swiftpm:ea137609d80
swift-corelibs-xctest:75d601cd8ca
swift-corelibs-foundation:576e6d966b8
swift-integration-tests:bade6e5395f

Joe

···

On Fri, Jan 1, 2016 at 12:46 PM, Joseph Bell <joe@iachieved.it> wrote:

I've confirmed that the lldb failure is with a pristine build environment
as well:

lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:146:79:
error: no member named 'getBodyParamPatterns' in 'swift::FuncDecl'
        llvm::MutableArrayRef<swift::Pattern *> lhs_patterns =
lhs_func_decl->getBodyParamPatterns();

~~~~~~~~~~~~~ ^

On Fri, Jan 1, 2016 at 10:55 AM, Joseph Bell <joe@iachieved.it> wrote:

Good morning and Happy New Year.

All repos updated with ./swift/utils/update-checkout --all as of 10AM
Central, and getting a compile failure on:

lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:146:79:
error: no member named 'getBodyParamPatterns' in 'swift::FuncDecl'
        llvm::MutableArrayRef<swift::Pattern *> lhs_patterns =
lhs_func_decl->getBodyParamPatterns();

I see a number of commits going into swift repo at the moment, can anyone
confirm rebuilding lldb against it?

Joe

--
---
http://dev.iachieved.it/iachievedit/
@iachievedit


(Chris Lattner) #6

Thanks! Hopefully ad4d065 will finish it off,

-Chris

···

On Jan 1, 2016, at 11:33 AM, Joseph Bell <joe@iachieved.it> wrote:

Chris:

One error down, a few more:
/lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:155:47: error: member reference type 'llvm::MutableArrayRef<swift::ParameterList *>' is not a pointer; maybe you meant to use '.'?
                auto *lhs_param = lhs_patterns->get(idx);
                                  ~~~~~~~~~~~~^~
                                              .
lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:155:49: error: no member named 'get' in 'llvm::MutableArrayRef<swift::ParameterList *>'
                auto *lhs_param = lhs_patterns->get(idx);
                                  ~~~~~~~~~~~~ ^
lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:156:47: error: member reference type 'llvm::MutableArrayRef<swift::ParameterList *>' is not a pointer; maybe you meant to use '.'?
                auto *rhs_param = rhs_patterns->get(idx);
                                  ~~~~~~~~~~~~^~
                                              .
lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:156:49: error: no member named 'get' in 'llvm::MutableArrayRef<swift::ParameterList *>'
                auto *rhs_param = rhs_patterns->get(idx);
                                  ~~~~~~~~~~~~ ^
4 errors generated.

followed by

lldb/source/Plugins/ExpressionParser/Swift/SwiftASTManipulator.cpp:1486:28: error: cannot use incomplete type 'swift::ParameterList' as a range
        for (auto &param : *paramList)
                           ^
swift/include/swift/AST/Identifier.h:30:9: note: forward declaration of 'swift::ParameterList'
  class ParameterList;
        ^
lldb/source/Plugins/ExpressionParser/Swift/SwiftASTManipulator.cpp:1487:36: error: use of undeclared identifier 'm_name'
            if (param.getName() == m_name)
                                   ^
2 errors generated.

This is with

cd lldb && git rev-parse HEAD
ea61c8a73a4eb6c818467bc497c83c125c697c9c

Thanks,
Joe

On Fri, Jan 1, 2016 at 1:15 PM, Chris Lattner <clattner@apple.com <mailto:clattner@apple.com>> wrote:
My fault, I think that ea61c8a should fix it, but I haven’t tested it. Can you please let me know if there is still a problem?

Thanks!

-Chris

On Jan 1, 2016, at 10:46 AM, Joseph Bell via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:

I've confirmed that the lldb failure is with a pristine build environment as well:

lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:146:79: error: no member named 'getBodyParamPatterns' in 'swift::FuncDecl'
        llvm::MutableArrayRef<swift::Pattern *> lhs_patterns = lhs_func_decl->getBodyParamPatterns();
                                                               ~~~~~~~~~~~~~ ^

On Fri, Jan 1, 2016 at 10:55 AM, Joseph Bell <joe@iachieved.it <mailto:joe@iachieved.it>> wrote:
Good morning and Happy New Year.

All repos updated with ./swift/utils/update-checkout --all as of 10AM Central, and getting a compile failure on:

lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:146:79: error: no member named 'getBodyParamPatterns' in 'swift::FuncDecl'
        llvm::MutableArrayRef<swift::Pattern *> lhs_patterns = lhs_func_decl->getBodyParamPatterns();

I see a number of commits going into swift repo at the moment, can anyone confirm rebuilding lldb against it?

Joe

_______________________________________________
swift-dev mailing list
swift-dev@swift.org <mailto:swift-dev@swift.org>
https://lists.swift.org/mailman/listinfo/swift-dev


(Chris Lattner) #7

Fantastic, thanks Joe!

-Chris

···

On Jan 1, 2016, at 2:02 PM, Joseph Bell <joe@iachieved.it> wrote:

Confirmed that as of the following revs the world builds and all tests passing:

% swift swiftrevs.swift
swift:c264b1eda0d
llvm:3ebdbb2c7e5
clang:f66c5bb67b9
lldb:37fa5a942ff
cmark:5af77f3c1d7
llbuild:7fba6e6213e
swiftpm:ea137609d80
swift-corelibs-xctest:75d601cd8ca
swift-corelibs-foundation:576e6d966b8
swift-integration-tests:bade6e5395f

Joe

On Fri, Jan 1, 2016 at 12:46 PM, Joseph Bell <joe@iachieved.it <mailto:joe@iachieved.it>> wrote:
I've confirmed that the lldb failure is with a pristine build environment as well:

lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:146:79: error: no member named 'getBodyParamPatterns' in 'swift::FuncDecl'
        llvm::MutableArrayRef<swift::Pattern *> lhs_patterns = lhs_func_decl->getBodyParamPatterns();
                                                               ~~~~~~~~~~~~~ ^

On Fri, Jan 1, 2016 at 10:55 AM, Joseph Bell <joe@iachieved.it <mailto:joe@iachieved.it>> wrote:
Good morning and Happy New Year.

All repos updated with ./swift/utils/update-checkout --all as of 10AM Central, and getting a compile failure on:

lldb/source/Plugins/ExpressionParser/Swift/SwiftPersistentExpressionState.cpp:146:79: error: no member named 'getBodyParamPatterns' in 'swift::FuncDecl'
        llvm::MutableArrayRef<swift::Pattern *> lhs_patterns = lhs_func_decl->getBodyParamPatterns();

I see a number of commits going into swift repo at the moment, can anyone confirm rebuilding lldb against it?

Joe

--
---
http://dev.iachieved.it/iachievedit/
@iachievedit