ArchetypeBuilder rename


(Douglas Gregor) #1

Hi all,

The ArchetypeBuilder <https://github.com/apple/swift/blob/master/include/swift/AST/ArchetypeBuilder.h> class, whose primary responsibility is to validate, minimize, and canonicalize generic signatures, now has almost nothing to do with archetypes. I’d like to rename it to GenericSignatureBuilder. Two questions:

1) Does anyone have an issue with this new name?
2) Other than https://github.com/apple/swift/pull/7313 and https://github.com/apple/swift/pull/7319, does anyone have significant outstanding changes to the ArchetypeBuilder for which rebasing after a rename would be awful? If so, I can hold off on the rename for a bit longer.

  - Doug


(Slava Pestov) #2

Do you mind if I merge https://github.com/apple/swift/pull/7319 first? It’s ready to go in.

Slava

···

On Feb 7, 2017, at 4:59 PM, Douglas Gregor via swift-dev <swift-dev@swift.org> wrote:

Hi all,

The ArchetypeBuilder <https://github.com/apple/swift/blob/master/include/swift/AST/ArchetypeBuilder.h> class, whose primary responsibility is to validate, minimize, and canonicalize generic signatures, now has almost nothing to do with archetypes. I’d like to rename it to GenericSignatureBuilder. Two questions:

1) Does anyone have an issue with this new name?
2) Other than https://github.com/apple/swift/pull/7313 and https://github.com/apple/swift/pull/7319, does anyone have significant outstanding changes to the ArchetypeBuilder for which rebasing after a rename would be awful? If so, I can hold off on the rename for a bit longer.

  - Doug

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev


(Douglas Gregor) #3

Go for it! I haven't even created the renaming PR and don't want to step on toes.

···

Sent from my iPhone

On Feb 7, 2017, at 7:13 PM, Slava Pestov <spestov@apple.com> wrote:

Do you mind if I merge https://github.com/apple/swift/pull/7319 first? It’s ready to go in.

Slava

On Feb 7, 2017, at 4:59 PM, Douglas Gregor via swift-dev <swift-dev@swift.org> wrote:

Hi all,

The ArchetypeBuilder class, whose primary responsibility is to validate, minimize, and canonicalize generic signatures, now has almost nothing to do with archetypes. I’d like to rename it to GenericSignatureBuilder. Two questions:

1) Does anyone have an issue with this new name?
2) Other than https://github.com/apple/swift/pull/7313 and https://github.com/apple/swift/pull/7319, does anyone have significant outstanding changes to the ArchetypeBuilder for which rebasing after a rename would be awful? If so, I can hold off on the rename for a bit longer.

  - Doug

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev


(Slava Pestov) #4

It’s merged. Rename all you want, see if I care!!!

···

On Feb 7, 2017, at 7:46 PM, Douglas Gregor <dgregor@apple.com> wrote:

Go for it! I haven't even created the renaming PR and don't want to step on toes.

Sent from my iPhone

On Feb 7, 2017, at 7:13 PM, Slava Pestov <spestov@apple.com <mailto:spestov@apple.com>> wrote:

Do you mind if I merge https://github.com/apple/swift/pull/7319 first? It’s ready to go in.

Slava

On Feb 7, 2017, at 4:59 PM, Douglas Gregor via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:

Hi all,

The ArchetypeBuilder <https://github.com/apple/swift/blob/master/include/swift/AST/ArchetypeBuilder.h> class, whose primary responsibility is to validate, minimize, and canonicalize generic signatures, now has almost nothing to do with archetypes. I’d like to rename it to GenericSignatureBuilder. Two questions:

1) Does anyone have an issue with this new name?
2) Other than https://github.com/apple/swift/pull/7313 and https://github.com/apple/swift/pull/7319, does anyone have significant outstanding changes to the ArchetypeBuilder for which rebasing after a rename would be awful? If so, I can hold off on the rename for a bit longer.

  - Doug

_______________________________________________
swift-dev mailing list
swift-dev@swift.org <mailto:swift-dev@swift.org>
https://lists.swift.org/mailman/listinfo/swift-dev