- The ability to customize the location of the Snippets source code.
- The ability to use Snippets as the underpinning for step-by-step guides, which requires additional primitives to presents "slices" of snippets, enabling progressive disclosure.
- The best syntax for defining the above slices, and communicate show/hide semantics
- The differences and tradeoffs between snippets, literate programing, and code listings.
While alternative approaches such as literate programing have advantages, the core team feels Snippets solve a real need in the Swift ecosystem in a focused and pragmatic way, adding immediate value, while paving the path for future evolution and improvements. As such, the proposal has been accepted with the following modifications:
- Update the proposal to allow users to override the default top level directory for Snippets (in the Package manifest). There may be some restrictions around this such as the custom location cannot overlap with source directories.
- Update the proposal to include a design for Snippets slices (as currently described in the future directions section), as well as step-by-step guides based on such slices.
- Update the proposal to more robustly describe how Snippets are different from literate programming and embedded code listing, highlighting the tradeoffs and why Snippets is the preferred solution. These alternatives are already mentioned in the proposal but have been brought up again the review, as such, it would be good to bring additional details from the review thread back to the proposal for future readers.
- Add additional clarifications in the body of the proposal about which dependencies are supported and which are not ,and reference the future direction section where this is discussed.
- Add additional clarifications in the future direction section about improving the infrastructure of testing Snippets (beyond just building them).
The authors revised the proposal to include these changes, and the core team accepted the proposal with these modifications.
Thank you to the proposal authors and everyone who participated in the review.