thanks Freddy. i'm not sure what the right venue for this form of feedback is, so hopefully posting here is alright (if not, perhaps someone with appropriate permissions could relocate it).
during the pitch & review for this feature, there were a number of issues raised regarding specifics of the associated implementation PR, the discussion of which received some pushback as 'detracting' from the intended focus on the design.
as someone who believes implementations matter quite a bit (after all, they are the only thing that brings a design 'to life', so to speak), my experience during this pitch & review has left me somewhat confused as to how implementation feedback is supposed to fit into this stage of the evolution process. in particular, these are a few questions i've been wondering about:
- does the LSG consider the proposed implementation and any associated PR discussion in its determinations?
- are proposal authors expected to respond to implementation feedback during the review?
- are review managers typically familiar with a feature's implementation and any PR feedback, or is that outside of the role's purview?
i was under the impression that the review period would be a good time to have 'extra eyes' on an implementation to try and catch issues before they ship. however, i noticed that the implementation PR was merged shortly after this acceptance announcement was posted, but a number of outstanding comments & questions were left unaddressed (disclaimer – most are mine). additionally, AFAICT there were no tests provided for the new functionality, despite this being a nominal requirement in the contributing guidelines[1].
having spent quite a bit of time and energy understanding the implementation and surfacing possible issues, the fact that that work appeared to both not be welcome in the review thread, and PR feedback was left seemingly ignored before the implementation was merged is both discouraging and a bit baffling.
anyway, the feature does seem interesting and potentially quite useful, even if i think it still has some problematic edge cases.