A large number of stdlib/Slice validation tests appear to be failing


(Brian Gesiak) #1

Hello!

I'm not sure if I'm the only person experiencing a problem, but using the
latest apple/swift commit (https://github.com/apple/swift/commit/ad33048a),
I'm experiencing a large number of validation-test failures:

- stdlib/Slice.swift.gyb

···

-
stdlib/Slice/MutableSlice_Of_DefaultedBidirectionalMutableCollection_FullWidth.swift.gyb
-
stdlib/Slice/MutableSlice_Of_DefaultedBidirectionalMutableCollection_WithPrefix.swift.gyb
    -
stdlib/Slice/MutableSlice_Of_DefaultedBidirectionalMutableCollection_WithPrefixAndSuffix.swift.gyb
-
stdlib/Slice/MutableSlice_Of_DefaultedBidirectionalMutableCollection_WithSuffix.swift.gyb
- ...and so on. There are about 60 failures.

All of them fail with the following:

/home/odocache/GitHub/apple/build/Ninja-ReleaseAssert/swift-linux-x86_64/lib/swift/linux/libswiftStdlibCollectionUnittest.so:
undefined reference to
`_TTSf4s_s_s_n_n___TFs16_assertionFailedFTVs12StaticStringSSS_Su5flagsVs6UInt32_T_'
clang-3.9: error: linker command failed with exit code 1 (use -v to see
invocation)
<unknown>:0: error: link command failed with exit code 1 (use -v to see
invocation)

'_assertionFailed' appears to be defined in
stdlib/public/core/AssertCommon.swift. I'm not sure what may have recently
changed to cause these test failures, but it must have been in the last 70
commits since ad33048a, since that build works for me.

I'll try running a bisect. In the meantime, I was wondering if anyone else
was experiencing this issue? Or am I doing something wrong?

Thanks!

- Brian Gesiak


(Brian Gesiak) #2

'_assertionFailed' appears to be defined in
stdlib/public/core/AssertCommon.swift. I'm not sure what may have recently
changed to cause these test failures, but it must have been in the last 70
commits since ad33048a, since that build works for me.

Sorry, just to clarify this statement: The tests passed for me on
https://github.com/apple/swift/commit/98d8686dc1e76c119034665ab05aae56712ced3d,
an earlier commit. I encountered the test failures after updating to
https://github.com/apple/swift/commit/ad33048af9003b117dfb7b6542d779c136b0b859
this morning.

I'll bisect the failures between these two points, but was wondering if
anyone else was aware of these failures.

Thanks!

- Brian Gesiak


(Mark Lacey) #3

Are you still seeing a failure?

The CI system doesn’t appear to be hitting this. It’s possible there is a build dependency problem and that this will clear up with a clean build. If that’s the case it would be great to track down the dependency problem and get that fixed.

Mark

···

On Feb 10, 2016, at 10:44 AM, Brian Gesiak via swift-dev <swift-dev@swift.org> wrote:

'_assertionFailed' appears to be defined in stdlib/public/core/AssertCommon.swift. I'm not sure what may have recently changed to cause these test failures, but it must have been in the last 70 commits since ad33048a, since that build works for me.

Sorry, just to clarify this statement: The tests passed for me on https://github.com/apple/swift/commit/98d8686dc1e76c119034665ab05aae56712ced3d, an earlier commit. I encountered the test failures after updating to https://github.com/apple/swift/commit/ad33048af9003b117dfb7b6542d779c136b0b859 this morning.

I'll bisect the failures between these two points, but was wondering if anyone else was aware of these failures.

Thanks!

- Brian Gesiak

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev


(Brian Gesiak) #4

Mark,

Thanks for the reply. Sure enough, a completely clean build fixed my issue.
I must have gotten my build in a wonky state. Thanks for your help!

I'll try and pinpoint what exactly may have happened, in case it's
something that could be fixed.

- Brian Gesiak

···

On Wed, Feb 10, 2016 at 3:05 PM, Mark Lacey <mark.lacey@apple.com> wrote:

Are you still seeing a failure?

The CI system doesn’t appear to be hitting this. It’s possible there is a
build dependency problem and that this will clear up with a clean build. If
that’s the case it would be great to track down the dependency problem and
get that fixed.

Mark

On Feb 10, 2016, at 10:44 AM, Brian Gesiak via swift-dev < > swift-dev@swift.org> wrote:

'_assertionFailed' appears to be defined in

stdlib/public/core/AssertCommon.swift. I'm not sure what may have recently
changed to cause these test failures, but it must have been in the last 70
commits since ad33048a, since that build works for me.

Sorry, just to clarify this statement: The tests passed for me on
https://github.com/apple/swift/commit/98d8686dc1e76c119034665ab05aae56712ced3d,
an earlier commit. I encountered the test failures after updating to
https://github.com/apple/swift/commit/ad33048af9003b117dfb7b6542d779c136b0b859
this morning.

I'll bisect the failures between these two points, but was wondering if
anyone else was aware of these failures.

Thanks!

- Brian Gesiak

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev