* What is your evaluation of the proposal?
+1. I've used unfold/iterate functions in Haskell and Clojure, and they are
very useful.
* Is the problem being addressed significant enough to warrant a
change to Swift?
Yes.
* Does this proposal fit well with the feel and direction of Swift?
Yes.
* If you have used other languages or libraries with a similar
feature, how do you feel that this proposal compares to those?
See above.
* How much effort did you put into your review? A glance, a quick
reading, or an in-depth study?
Quick reading.
Also note that there's a typo in the second example:
for view in sequence(initial: someView, next: { $0.superview }) {
// someView, someView.superview, someView.superview.superview, ...
}
should be:
for view in sequence(state: someView, next: { $0.superview }) {
// someView, someView.superview, someView.superview.superview, ...
}
···
On Thu, May 19, 2016 at 6:29 PM, Chris Lattner via swift-evolution < swift-evolution@swift.org> wrote:
Hello Swift community,
The review of "SE-0094: Add sequence(initial:next:) and
sequence(state:next:) to the stdlib" begins now and runs through May 23.
This is a refinement of part of SE-0045. The proposal is available here:https://github.com/apple/swift-evolution/blob/master/proposals/0094-sequence-function.md
Reviews are an important part of the Swift evolution process. All reviews
should be sent to the swift-evolution mailing list athttps://lists.swift.org/mailman/listinfo/swift-evolution
or, if you would like to keep your feedback private, directly to the
review manager.What goes into a review?
The goal of the review process is to improve the proposal under review
through constructive criticism and contribute to the direction of Swift.
When writing your review, here are some questions you might want to answer
in your review:* What is your evaluation of the proposal?
* Is the problem being addressed significant enough to warrant a
change to Swift?
* Does this proposal fit well with the feel and direction of Swift?
* If you have used other languages or libraries with a similar
feature, how do you feel that this proposal compares to those?
* How much effort did you put into your review? A glance, a quick
reading, or an in-depth study?More information about the Swift evolution process is available at
https://github.com/apple/swift-evolution/blob/master/process.md
Thank you,
-Chris Lattner
Review Manager
_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution
--
Trent Nadeau