[Review, 2nd] SF-0007: Subprocess

gregcotten · December 29, 2024, 5:11pm

FileDescriptor's rawValue on Windows can be converted into a HANDLE, apparently: swift-experimental-subprocess/Sources/Subprocess/Platforms/Subprocess+Windows.swift at f0c43633431030e4b1ff622ea29c23a3dc60ed4b · iCharlesHu/swift-experimental-subprocess · GitHub

github.com

iCharlesHu/swift-experimental-subprocess/blob/f0c43633431030e4b1ff622ea29c23a3dc60ed4b/Sources/Subprocess/Platforms/Subprocess+Windows.swift#L940


      
              private static func pathAccessible(_ path: String) -> Bool {
                  return path.withCString(encodedAs: UTF16.self) {
                      let attrs = GetFileAttributesW($0)
                      return attrs != INVALID_FILE_ATTRIBUTES
                  }
              }
          }
          
          // MARK: - PlatformFileDescriptor Type
          extension Subprocess {
              internal typealias PlatformFileDescriptor = HANDLE
          }
          
          // MARK: - Read Buffer Size
          extension Subprocess {
              @inline(__always)
              internal static var readBufferSize: Int {
                  // FIXME: Use Platform.pageSize here
                  var sysInfo: SYSTEM_INFO = SYSTEM_INFO()
                  GetSystemInfo(&sysInfo)
                  return Int(sysInfo.dwPageSize)

Looks like it!

github.com

iCharlesHu/swift-experimental-subprocess/blob/f0c43633431030e4b1ff622ea29c23a3dc60ed4b/Sources/Subprocess/Platforms/Subprocess+Windows.swift#L773


      
              return DWORD(flags)
          }
          
          private func generateStartupInfo(
              withInput input: Subprocess.ExecutionInput,
              output: Subprocess.ExecutionOutput,
              error: Subprocess.ExecutionOutput
          ) throws -> STARTUPINFOW {
              var info: STARTUPINFOW = STARTUPINFOW()
              info.cb = DWORD(MemoryLayout<STARTUPINFOW>.size)
              info.dwFlags |= DWORD(STARTF_USESTDHANDLES)
          
              if self.platformOptions.windowStyle.storage != .normal {
                  info.wShowWindow = self.platformOptions.windowStyle.platformStyle
                  info.dwFlags |= DWORD(STARTF_USESHOWWINDOW)
              }
              // Bind IOs
              // Input
              if let inputRead = input.getReadFileDescriptor() {
                  info.hStdInput = inputRead.platformDescriptor
              }

I'd assume PRs or Issues are welcome on the actual GitHub project...