Let's fix `if let` syntax

[hisekaldma (Jonathan Hise Kaldma)]

@jawbroken

That it doesn't naturally work to unwrap other.thing is a feature to me, because you should probably think about giving other.thing a different name in this scope (e.g. otherThing , specificThing ), as opposed to if let x where x should already be a name that makes contextual sense.

FWIW, when it’s just a simple property access, in our codebase it’s mostly if let thing = other.thing and not if let otherThing = other.thing. I think the reason is that often there’s only a single other you’re doing something with, so the context is clear enough. The unwrappings that get more descriptive names are the ones where there is a longer optional chain or function call involved. But even then, sometimes it’s just if let thing = other.third?.thing.